New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce flags for line and form coverage thresholds #343
base: master
Are you sure you want to change the base?
Conversation
11229b8
to
698e9ad
Compare
698e9ad
to
162112b
Compare
@vemv Cloud you please review this? |
It would help us to understand, what would be a typical use case for this? If there's one that's easy to understand, it would seem worthwhile adding it to the readme |
@vemv Thanks for getting back to me! The use case for our project is that the form coverage is pretty low at the moment due to some macros, but our line coverage is high enough for our standards. Until we can raise the form coverage (if we ever do that), we would like to set the line and form thresholds separately to check that at least our line coverage is up to standards in all our repos. Apart from the description of the new flags in the readme, should I describe this use case as well? |
Thanks! A brief description like this one should suffice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
Co-authored-by: vemv <vemv@users.noreply.github.com>
@vemv Thanks for the suggestions, please check my latest commits with the added unit test, the updated readme and the added (@imrekoszo fyi) |
a6b98e6
to
3871a34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me - great work!
(Note: I don't have write access. I was pinged so here's my review)
Hi @lvh, do you have write access to this repo? If yes, could you please review this PR? thanks in advance! |
Fixes #344
Introduce flags
--line-fail-threshold
and--form-fail-threshold
for the option to handle the two coverages separately. Build will fail if line coverage is below--line-fail-threshold
or form coverage is below--form-fail-threshold
.Ignore new flags if
--fail-threshold
is non-zero in which case the build fails if either line or form coverage is belowfail-threshold
(same as before).