Support for cobertura reports #325
Conversation
|
This LGTM so far; let me know when it's ready for review in your opinion. |
|
Yeah so far I had just pretty much copied Emma XML code and was trying to find good input/output for testing, and then actually implement the missing logic. I think btw (as unrelated topic) that at the moment:
If you use https://github.com/lambdaisland/kaocha or happy to use it for this project I can add that in another PR, you could even publish the results to https://about.codecov.io/. |
|
That would be awesome! I agree there are no such tests right now but there
is no good reason for that.
…On Mon, Sep 20, 2021 at 8:44 AM Andrea Crotti ***@***.***> wrote:
Yeah so far I had just pretty much copied Emma XML code and was trying to
find good input/output for testing, and then actually implement the missing
logic.
I think btw (as unrelated topic) that at the moment:
- there aren't end-to-end tests for the reporting for most formats
- cloverage itself is not set up to run test coverage against itself
(which I just wanted to run to check if I was missing something)
If you use https://github.com/lambdaisland/kaocha or happy to use it for
this project I can add that in another PR, you could even publish the
results to https://about.codecov.io/.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#325 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAX4GA7VD7QODF67YSOQKTUC43EHANCNFSM5ELZWKTA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
lvh
|
|
I've added end-to-end test for all the current reporters in my other PR eb41538 |
AndreaCrotti
force-pushed
the
cobertura
branch
2 times, most recently
from
6952291
to
c7a3f15
Compare
AndreaCrotti
force-pushed
the
cobertura
branch
from
c7a3f15
to
c20e406
Compare
|
Annoyingly, looks like that other kaocha PR broke: but not the testing part, just one of the new tests. |
|
Ah no I'm aware the test is broken, just because it's not ready yet. I'll comment here when it's ready to review |
|
Ah, oops, of course :D Thanks!
…On Sat, Sep 25, 2021 at 12:20 PM Andrea Crotti ***@***.***> wrote:
Ah no I'm aware the test is broken, just because it's not ready yet. I'll
comment here when it's ready to review
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#325 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAX4GFS23UZAC7HIH2QF2DUDYAFXANCNFSM5ELZWKTA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
lvh
|
|
And btw if you could turn the circleci integration on @lvh, we could see the CI status directly here in the PR.. |
|
Hm. I think the reason it wasn't doing that was because this was a forked pull rquest, but it's a little hard to debug. Hopefully fixed now. |
|
Ah yes closing and reopening the PR fixed it, thanks @lvh |
|
@lvh @AndreaCrotti any plans to merge this PR? |
|
@prathik As the PR indicates it's not ready yet, so, no, not until it is. |
|
Yes sorry there is still a bit of work to do there. |
|
Thanks @AndreaCrotti , let me know if there is anything I can help with as well, let's divide and conquer, and get this out! |
No description provided.