Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add location param to bqr_get_job #72

Merged
merged 1 commit into from
May 20, 2024

Conversation

ekocsis3
Copy link
Contributor

Hi @MarkEdmondson1234,

Here is my implementation of the bqr_get_job location param as discussed in issue #71.
The location is either parsed from the job object or takes the user input. NULL value is accepted for backward compatibility, which still works for EU and US location.
Within the package job location is passed to the function whenever it is called.

I didn't add any tests as it would require datasets in a different location, but it worked in my 'testing environment'.

Cheers,
Eszter

@MarkEdmondson1234
Copy link
Collaborator

Thanks! Will take a look. Please do add yourself as a contributor to the Authors in the DESCRIPTION as well if you wish.

@emilmahler
Copy link

@MarkEdmondson1234 could you pull this branch in please? We are moving to specific regions (low CO2) now, making this a necessary change.

@MarkEdmondson1234 MarkEdmondson1234 merged commit 13c6307 into cloudyr:master May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants