WIP: feat: io_uring for netpoll I/O poller #197

Jacob953 · 2022-08-25T08:16:43Z

Follows #151, tracing at #194. Hold, please ;)

…r.polls

Hchenn · 2022-08-30T03:15:06Z

uring/sys_enter.go

+
+	// If the ring is initialized with IORING_SETUP_CQE32, then this field
+	// contains 16-bytes of padding, doubling the size of the CQE.
+	BigCQE []uint64


16bytes 应该是 [2]uint64 吧，这样定义怎么初始化呢

Hchenn · 2022-08-30T03:20:56Z

uring/sys_enter.go

+	Len         uint32 // buffer size or number of iovecs
+	OpcodeFlags uint32
+	UserData    uint64 // data to be passed back at completion time
+


以下先 pad [3]uint64 吧，这里 union 先不区分

Hchenn · 2022-08-30T03:21:20Z

uring/sys_enter.go

+	Off         uint64 // offset into file
+	Addr        uint64 // pointer to buffer or iovecs
+	Len         uint32 // buffer size or number of iovecs
+	OpcodeFlags uint32


this is UnionFlags

Hchenn · 2022-08-30T03:22:54Z

uring/sys_mmap.go

+// sysMmap is used to configure the URingSQE and URingCQE,
+// it should only be called after the sysSetUp function has completed successfully.
+func (u *URing) sysMmap(p *ringParams) (err error) {
+	size := unsafe.Sizeof(URingCQE{})


sizeof 定义为 global var/const，不用每次都算

Hchenn · 2022-08-30T03:26:16Z

uring/sys_mmap.go

+	}
+
+	// TODO: syscall.MAP_POPULATE unsupport for macox
+	data, err := syscall.Mmap(u.fd, 0, int(u.sqRing.ringSize), syscall.PROT_READ|syscall.PROT_WRITE, syscall.MAP_SHARED)


syscall.Mmap/Unmap 封装一下，以后可以修改

uring 不是 only linux 吗，为什么考虑 macox ? 这里没有 syscall.MAP_POPULATE 不行的

Hchenn · 2022-08-30T03:37:16Z

uring/syscall.go

+	"syscall"
+	"unsafe"
+)
+


public 这个文件的所有方法，sdk 应该支持直接 syscall

Hchenn · 2022-08-30T03:37:58Z

uring/syscall.go

+}
+
+//go:linkname sockaddr syscall.Sockaddr.sockaddr
+func sockaddr(addr syscall.Sockaddr) (unsafe.Pointer, uint32, error)


没看到使用地方，先从这里移出吧，不是一个分类

Hchenn · 2022-08-30T03:39:33Z

uring/uring.go

+}
+
+// IOURing create new io_uring instance with Setup Options
+func IOURing(entries uint32, ops ...setupOp) (r *URing, err error) {


入口文件，请把用户能调的放在最前面，私有内容放后面，或者放其他文件里

Hchenn · 2022-08-30T03:40:55Z

uring/uring.go

+}
+
+// Init system call numbers
+const (


这些 const 扔到 syscall.go 里

Hchenn · 2022-08-30T03:42:41Z

uring/uring_cmplt.go

+}
+
+// GetEventsArg implements URing
+func GetEventsArg(sigMask uintptr, sigMaskSz uint32, ts uintptr) *getEventsArg {


global func 别混在这里，如果是 private, 小写放最后；public 就放其他文件归类

Hchenn · 2022-08-30T03:44:07Z

poll_default_bsd.go

@@ -25,7 +25,10 @@ import (
 	"unsafe"
 )

-func openPoll() Poll {


poll_xxx 这些先删掉吧，这里需要开发注册机制，不通过 type 区分

Hchenn · 2022-08-30T03:44:17Z

poll_io_uring.go

+
+package netpoll
+
+import uring "github.com/cloudwego/netpoll/io_uring"


路径错误

Hchenn · 2022-08-30T03:44:47Z

poll_io_uring.go

@@ -0,0 +1,45 @@
+// Copyright 2021 CloudWeGo Authors


…/io_uring

Jacob953 · 2022-10-12T20:21:13Z

Run go test -bench=".*" -benchtime=1000000x at uring/benchmark/ .

goos: linux
goarch: arm64
pkg: github.com/cloudwego/netpoll/uring/benchmark
BenchmarkEpoll-4   	 1000000	      1232 ns/op
BenchmarkUring-4   	 1000000	       457.4 ns/op
PASS

CLAassistant · 2022-11-22T06:32:29Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Jacob953 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Jacob953 added 4 commits August 25, 2022 03:03

feat: add variable parameters to manager.Run() for PollType of manage…

d766619

…r.polls

feat: re-design openPoll() to select one PollType

0227947

feat: add IOURingPoll (WIP)

bb5ef53

feat: add sysMmap & sysMunmap

16074e4

Hchenn added the feature label Aug 25, 2022

Jacob953 added 12 commits August 27, 2022 22:24

fix: rename io_uring to uring

00ee563

fix: uniform variable r to u

04cd494

feat: add const for mmap

a940bfa

feat: add setup, enter & register for system call

a375d8c

feat: add setup options

3e90d2b

feat: add SQEntry & CQEvent

8db732f

feat: add atomic operation for barrier

ea33f82

feat: add probe supported capability

fda4b12

feat: add advance usage for register

7f9768b

feat: add uring for low-level interface

fdc0e5b

feat: add submission operations

4c5b712

feat: add completion operations

641d782

Hchenn reviewed Aug 30, 2022

View reviewed changes

poll_io_uring.go Outdated

@@ -0,0 +1,45 @@

// Copyright 2021 CloudWeGo Authors

Copy link

Contributor

Hchenn Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright 2022 CloudWeGo Authors

Jacob953 added 10 commits September 8, 2022 00:26

fix: restructure URingSQE & URingCQE

8e81931

fix: wrap mmap & unmmap, recovery syscall.MAP_POPULATE

1057583

faet: public getOp by Op

a02b287

fix: update sysRegister to SysRegister

58d195d

feat: public syscall

4fab811

feat: restructure uring methord

e3f4b83

fix: remove sys_barrier.go

392c003

fix: rollback poll_default_* & poll_manager

61f407b

feat: restructure URingCQE, Error & rename setData to setUserData

c82d419

Junfeng and others added 6 commits October 10, 2022 11:44

Merge branch 'cloudwego:develop' into feat/io_uring

f86c99a

fix: rename cq.kRingMsk to cq.kRingMask, add annotation

cdbc94f

feat: update peekBatchCQE & peekCQE, and add getEvents

c1ec061

fix: rename cq.kRingMsk to cq.kRingMask

6a4d7e2

feat: add benckmark for uring & epoll

e9ff6a3

Merge branch 'feat/io_uring' of github.com:Jacob953/netpoll into feat…

7c65c95

…/io_uring

Jacob953 added 21 commits October 13, 2022 05:34

feat: add memory_barrier

46ca4cf

fix: TestTimeoutWait not supported

83cc3e2

fix: update SMP_MEMORY_BARRIER

93dda0b

feat: implement netpoll poller register

625c0c4

fix: rm poll_io_uring.go for restructuring

0013936

fix: rm SMP_SQRING.Store() at SysSetup

302e5be

fix: openPoll segmentation violation

03248a3

fix: simplify

5e0b446

feat: modify OpFlag

4d8abb9

feat: add RegisterURingPoll

ac1a9d8

feat: update pollRegister

e1a8711

feat: update go version to 1.17 for unsafe.Add

9dbdc9d

feat: add register for event, rm opflag

d2b3966

feat: add PollAdd & PollRemove

5a6033f

feat: add uring poller

4608460

fix: rm fmt(for test)

0737179

feat: add URingEpollCtl

ef05b54

fix: restructure uringpoll

326225e

fix: check trig and exit first

861cfa8

fix: add PollAdd for listen

dbd117a

feat: restructure Control

cfc5b9a

Jacob953 force-pushed the feat/io_uring branch from 4d19083 to cfc5b9a Compare October 18, 2022 00:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: feat: io_uring for netpoll I/O poller #197

WIP: feat: io_uring for netpoll I/O poller #197

Jacob953 commented Aug 25, 2022 •

edited

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Hchenn Aug 30, 2022

Jacob953 commented Oct 12, 2022

CLAassistant commented Nov 22, 2022


		package netpoll

		import uring "github.com/cloudwego/netpoll/io_uring"

WIP: feat: io_uring for netpoll I/O poller #197

Are you sure you want to change the base?

WIP: feat: io_uring for netpoll I/O poller #197

Conversation

Jacob953 commented Aug 25, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jacob953 commented Oct 12, 2022

CLAassistant commented Nov 22, 2022

Jacob953 commented Aug 25, 2022 •

edited