Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for NUMERIC data type #57

Merged
merged 3 commits into from Oct 2, 2020
Merged

feat: add support for NUMERIC data type #57

merged 3 commits into from Oct 2, 2020

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Sep 14, 2020 •
edited

Adds support for NUMERIC to Cloud Spanner Change Watcher.

Fixes #56

@googlebot googlebot added the cla: yes CLA signed label Sep 14, 2020
@olavloite
Copy link
Collaborator Author

This change depends on the fix in googleapis/java-spanner#425.

@olavloite
Copy link
Collaborator Author

cc @thiagotnunes

@olavloite
Copy link
Collaborator Author

@skuruppu Friendly ping on this. This will add support for NUMERIC columns to spanner-change-watcher.

@olavloite olavloite merged commit cad83d8 into master Oct 2, 2020
@olavloite olavloite deleted the numeric branch October 2, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagotnunes thiagotnunes thiagotnunes approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

@rosefliu rosefliu Awaiting requested review from rosefliu

Assignees
No one assigned
Labels
cla: yes CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add support for the new NUMERIC data type
3 participants
@olavloite @thiagotnunes @googlebot