Supported Colors and Terraform 12 JSON diff secrets masking #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Ugh, looks like when I wrote the github action I forgot to actually run the tests. :/ Any chance you can add that? Otherwise, I'll have @aknysh take a look. |
|
Hey @osterman, I'm super swamped with deployments right now. Happy to review though. |
|
@mnatan thanks for the PR, please rebase |
|
@aknysh rebased |
|
This is really useful when using with Helmfile provider. Would be good if it can be merged soon if it looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to @1n for figuring out a way of stripping ANSI colours and diffing.
We are using this project with terraform-provider-helmfile.
It tends to generate big diffs with JSON and YAML files pretty printed and we sometimes see secrets leaking to the screen.
To support masking these cases we decided to just detect secrets with regex on ANSI-stripped terraform output and saving them to a new genericMatch structure.
It contains a list of confidential strings, that are then masked in ANSI-colored output before we print it out to the screen.
The whole codebase can be adapted to this approach, however due to time constraints, I was unable to do so.