Update Terraform github.com/cloudposse/terraform-aws-s3-log-storage to v1 (main) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
tags/0.1.3->1.4.2Release Notes
cloudposse/terraform-aws-s3-log-storage (github.com/cloudposse/terraform-aws-s3-log-storage)
v1.4.2Compare Source
🚀 Enhancements
Add `grants` input @Nuru (#93)
what
grantsinputwhy
references
v1.4.1Compare Source
Sync .github @max-lobur (#89)
Rebuild '.github' dir from the template
🚀 Enhancements
Update Terraform cloudposse/s3-bucket/aws to v3.1.2 (main) @renovate (#91)
This PR contains the following updates:
3.1.1->3.1.2Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.2: Fix Public Bucket CreationCompare Source
What's Changed
New Contributors
Full Changelog: cloudposse/terraform-aws-s3-bucket@3.1.1...3.1.2
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v3.1.2 (main) @renovate (#91)
This PR contains the following updates:
3.1.1->3.1.2Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.2: Fix Public Bucket CreationCompare Source
What's Changed
New Contributors
Full Changelog: cloudposse/terraform-aws-s3-bucket@3.1.1...3.1.2
v1.4.0Compare Source
v1.3.1Compare Source
🚀 Enhancements
Update Terraform cloudposse/s3-bucket/aws to v3.1.1 (master) @renovate (#88)
This PR contains the following updates:
3.1.0->3.1.1Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.1Compare Source
🐛 Bug Fixes
Revert change to Transfer Acceleration from #​178 @​Nuru (#​180)
what
why
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v3.1.1 (master) @renovate (#88)
This PR contains the following updates:
3.1.0->3.1.1Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.1Compare Source
🐛 Bug Fixes
Revert change to Transfer Acceleration from #​178 @​Nuru (#​180)
what
why
v1.3.0Compare Source
🚀 Enhancements
Enhance lifecycle object with optionals, limit length of bucket name @Nuru (#87)
what
lifecycle_configuration_rulesto be fully defined with optional memberswhy
references
v1.2.0: Support new AWS S3 defaults (ACL prohibited)Compare Source
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v3.1.0 @renovate (#85)
This PR contains the following updates:
3.0.0->3.1.0Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.0Compare Source
Make compatible with new S3 defaults. Add user permissions boundary. @​Nuru (#​178)
what
aws_s3_bucket_accelerate_configurationandaws_s3_bucket_versioningresources even when the feature is disabled, to enable drift detectionwhy
references
Always include `aws_s3_bucket_versioning` resource @​mviamari (#​172)
what
aws_s3_bucket_versioningresource to track changes made to bucket versioning configurationwhy
aws_s3_bucket_versioning, the expectation is that the bucket versioning is disabled/suspend for the bucket. If bucket versioning is turned on outside of terraform (e.g. through the console), the change is not detected by terraform unless theaws_s3_bucket_versioningresource exists.references
Add support for permission boundaries on replication IAM role @​mchristopher (#​170)
what
why
references
🤖 Automatic Updates
Update README.md and docs @​cloudpossebot (#​164)
what
This is an auto-generated PR that updates the README.md and docs
why
To have most recent changes of README.md and doc from origin templates
v1.1.0Compare Source
Adding "object_lock_configuration" variable @ramses999 (#84)
what
Adding "object_lock_configuration" variable which is used in module "cloudposse/s3-bucket/aws"
why
Must be able to use the Object Lock option for S3 in this module
references
https://github.com/cloudposse/terraform-aws-s3-bucket/blob/6837ed7b2f2460043d6be3981f16ed90563fd12a/main.tf#L5
v1.0.0Compare Source
Important Notes
bucket_key_enabledflag defaults tofalsefor backward compatibility. At one point we recommend setting it to true for significant savings on KMS usage, but since bucket keys are only reused within a user session, it is not clear if it provides any savings at all. See AWS docs for more information.lifecycle_configuration_rulesinput replaces the now deprecated individual inputs for individual settings of a single lifecycle rule. See the terraform-aws-s3-bucket documentation for details on how to specify lifecycles usinglifecycle_configuration_rules. This mechanism is much more flexible and closely follows the Terraformaws_s3_bucket_lifecycle_configurationresource.source_policy_documentsinput replaces the now deprecatedpolicyinput to match changes to theaws_iam_policy_documentresourcenullforce_destroyat its default value offalse, and if you have it set totruebut want extra safety against the S3 bucket being destroyed, set it tofalsebefore upgrading).force_destroy_enabledflag introduced in v0.27.0 has been removedlifecycle_configuration_rulesinput was introduced. In that version, you would continue to get the old default lifecycle rule even if you supplied new rules vialifecycle_configuration_rules. Now, the default behavior is to ignore all the deprecated lifecycle inputs when thelifecycle_configuration_rulesinput is not empty, unless you explicitly setlifecycle_rule_enabledto true.Enhancements
Automate upgrade using `moved` blocks @Nuru (#81)
what
movedblock functionality introduced in Terraform 1.3.0nullable = falsefor module input variables which have a default value and where null is not a sensible/handled value for the variable.why
null, closes #63v1Compare Source
v0.28.3: Not recommended, use v0.26.0 or v1.x insteadCompare Source
Update: This version no longer recommended
With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v3 @renovate (#78)
This PR contains the following updates:
2.0.1->3.0.0v0.28.2: Action required if updating from prior to v0.28.0Compare Source
Update: This version no longer recommended
With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.
v0.28.0 introduced breaking changes with high risk of permanent data loss. See release notes there. This is only a safe upgrade if upgrading from v0.28.0.
We will convert to semantic versioning (incrementing the major version number for breaking changes), but having missed the opportunity to do that for earlier versions of this module, we are waiting for the next major change, expected to be soon after Terraform v1.3 is released.
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v2.0.1 @renovate (#76)
This PR contains the following updates:
2.0.0->2.0.1v0.28.1: accidental release, do not useCompare Source
v0.28.0 introduced breaking changes with high risk of permanent data loss. See release notes there. This is only a safe upgrade if upgrading from v0.28.0.
We will convert to semantic versioning (incrementing the major version number for breaking changes), but having missed the opportunity to do that for earlier versions of this module, we are waiting for the next major change, expected to be soon after Terraform v1.3 is released.
git.io->cloudposse.tools update @dylanbannon (#73)
what and why
Change all references to
git.io/build-harnessintocloudposse.tools/build-harness, sincegit.ioredirects will stop working on April 29th, 2022.References
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v2 @renovate (#72)
This PR contains the following updates:
0.49.0->2.0.3v0.28.0: (Action Needed) Support AWS v4 providerCompare Source
WARNING, DATA LOSS LIKELY if you do not follow upgrade instructions:
🚀 Enhancements
Support AWS v4 provider @Nuru (#71)
what
null-labelforce_destroy_enabledwhy
references
v0.27.0: (WARNING: Potential Data Loss) Prepare for AWS provider v4Compare Source
Update: This version no longer recommended
With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.
Warning: Potential total data loss
This release is a refactoring in preparation for supporting Terraform AWS Provider v4. One feature was removed, but otherwise there are no changes to inputs or behavior. However, the Terraform "addresses" of resources have changed, so you are need to run several
terraform state mvcommands.Warning: failure to run the required
terraform state mvcommands will cause Terraform to delete your existing S3 bucket and create a new one, deleting all the data stored in the bucket in the process.Details on how to safely upgrade are in this repository's Wiki here
Support for "MFA delete" removed
In #54 a contributor added support for MFA delete via the
versioning_mfa_delete_enabled. In AWS provider version 3.x this argument was documented with the caveatWith AWS provider version 4.0, this argument now does toggle the setting. Unfortunately, that adds the requirement then when it is enabled, you must supply a current MFA token every time you run
terraform apply. That is not compatible with automation, and therefore we have no intention to support it and have removed theversioning_mfa_delete_enabledinput.🚀 Enhancements
Refactor to use s3-bucket module, update in general @Nuru (#66)
what
mfa_delete< 4.0and disable Renovate bot, closes #64why
mfa_deleteenabled requires entering an MFA token for every Terraform operation, which is incompatible with automation. Users requiringmfa_deleteshould either not use Terraform or create their own fork.notes
This is the first of 2 upgrade releases to get this module to support Terraform AWS Provider v4. We are breaking it into 2 releases so that users have the option of upgrading step-by-step rather than all at once. Upgrade instructions are here.
Cleanups and safety checks for upgrade @Nuru (#70)
what
force_destroyistruewhy
force_destroyistruethen an automated, unattended process could cause the S3 bucket to be deleted and all data in it irretrievably lostreferences
Closes Renovate PRs:
build-harness)v0.26.0: Latest recommended v0 releaseCompare Source
This is the latest recommended v0.x version to use.
If this version does not meet your needs, please switch to version 1.x, and review the release notes for v1.0.0 for guidance on the differences.
Changes in this release
Add S3 bucket ownership controls @max-lobur (#61)
what
why
bucket-owner-full-controlACL is specified, the bucket account take ownership, otherwise the writer account keeps ownership. Bucket on its side may enforce presence of thebucket-owner-full-controlACL which we already do when needed. So this setting was the only missing piece to make ownership work like we expectedObjectWriter. It corresponds to legacy S3 behavior which was broken for us. Decided to always set toBucketOwnerPreferredand not allow to customize. If the owner must be preserved, we should not passbucket-owner-full-control- this is a more clear way to control the behavior.references
v0.25.0Compare Source
Add support for bucket notifications @max-lobur (#60)
what
why
v0.24.1Compare Source
🤖 Automatic Updates
Update context.tf @cloudpossebot (#59)
what
This is an auto-generated PR that updates the
context.tffile to the latest version fromcloudposse/terraform-null-labelwhy
To support all the features of the
contextinterface.v0.24.0Compare Source
Add variable access_log_bucket_prefix to customize S3 access log configuration @adamantike (#57)
What
Allow changing the prefix to be used in the specified S3 bucket for access logs.
Maintain current prefix as default value, for backwards compatibility.
Why
This is useful for projects using different standards (e.g. path with bucket name in the root folder).
v0.23.0Compare Source
add allow_ssl_requests_only flag @mcalhoun (#56)
what
why
data "aws_partition"v0.22.0Compare Source
add allow_ssl_requests_only flag @mcalhoun (#55)
what
allow_ssl_requests_onlyflag to force the bucket to be accessed via TLS onlywhy
references
v0.21.0Compare Source
added versioning mfa delete enabled option @chafnan (#54)
what
This adds the option to turn on MFA Delete for the bucket.
why
issue #48 does a good job explaining, but pasted important information below
Security best practices for CloudTrail logs that are stored in S3 recommend MFA Delete be enabled.
https://www.cloudconformity.com/knowledge-base/aws/CloudTrail/cloudtrail-bucket-mfa-delete-enabled.html
references
closes #48
v0.20.0Compare Source
context.tf updated to v0.24.1, minimum required Terraform version bumped to 0.13.0 when needed, readme updated @maximmi (#53)
what
why
v0.19.0Compare Source
minimum required Terraform version bumped to 0.13.0, context.tf updated, readme updated @maximmi (#52)
what
why
v0.18.1Compare Source
🤖 Automatic Updates
Update README.md and docs @cloudpossebot (#51)
what
This is an auto-generated PR that updates the README.md and docs
why
To have most recent changes of README.md and doc from origin templates
v0.18.0Compare Source
Bc compliance @maximmi (#49)
what
S3 bucket MFA deleteenabled by defaultS3 Bucket Versioningenabled by defaultEncryption of the S3 bucketenabled by defaultwhy
references
v0.17.0Compare Source
Terraform 0.14 upgrade @maximmi (#46)
what
why
v0.16.0Compare Source
Terraform 0.14 upgrade @Nuru (#44)
what
why
v0.15.1Compare Source
Configure Renovate @renovate (#40)
Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.
🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.
Detected Package Files
.github/workflows/auto-release.yml(github-actions).github/workflows/chatops.yml(github-actions)context.tf(terraform)versions.tf(terraform)Configuration
🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.
Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.
What to Expect
With your current configuration, Renovate will create 1 Pull Request:
Update cloudposse/actions action to v0.22.0
renovate/cloudposse-actions-0.xmaster0.22.0❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.
This PR has been generated by WhiteSource Renovate. View repository job log here.
v0.15.0Compare Source
Support terraform v0.14 @dmattia (#42)
v0.14.0Compare Source
Update to `context.tf`. Update Terratest to Golang modules. Update GitHub Actions. Allow TF 0.13 @aknysh (#39)
what
context.tfwhy
v0.13.1Compare Source
v0.13.0Compare Source
v0.12.0: Allow access logging to be enabledCompare Source
Allow access logging to be enabled on s3 bucket
what
access_log_bucket_nameto be target bucket for access logswhy
expect s3 buckets to have access logs enabled
references
v0.11.0Compare Source
Adding
enabledcount attribute to bucket policyv0.10.0Compare Source
Adding abort_incomplete_multipart_upload_days
Match lyfecycle rules from https://github.com/cloudposse/terraform-aws-s3-bucket
v0.9.0: Add blocking of public access to the bucketCompare Source
what
why
v0.8.0: Optional transitions to glacierCompare Source
what
why
v0.7.0: Update to latest label module to support the environment attributeCompare Source
what
why
environmentattribute is useful for naming resources (along withnamespace,stageandname), and the latest version oflabelmodule supports itv0.6.0Compare Source
v0.5.0: Convert to TF 0.12. Add tests. Add Codefresh test pipelineCompare Source
what
batsandterratestfor the exampleterraform-modulesprojectwhy
terraform-modulesproject contains pipelines for all terraform modulesv0.4.1Compare Source
v0.4.0: Fix lifecycle tagsCompare Source
what
why
The
tagsgenerated by the label module were propagated to the S3 Lifecycle filters, this is in general not desired, as it means the lifecycle only applies to objects with those tags.Console help message for the setting:
This adds a new var
lifecycle_tagswhich is a map of the tags to apply to the lifecycle rule.references
v0.3.1: Update readme yaml file and rebuild mdCompare Source
what
README.yamlfileREADME.mdfilewhy
v0.3.0: Add enabled flagCompare Source
what
why
v0.2.2: Regenerate README.mdCompare Source
what
README.mdwhy
v0.2.1: Migrate to README.yaml formatCompare Source
what
README.yamlwhy
v0.2.0Compare Source
what
why
references
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.