Fix: Zone creation fails when allow list does not contain all default groups #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in a zone that are mentioned in the groups allow list
… are mentioned in the allow list for groups
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187563344 The labels on this github issue will be updated when the story is started. |
…es-not-contain-all-default-groups
…psUsageShouldSucceed
This reverts commit 884416d.
…psUsageShouldSucceed
There was a problem hiding this comment.
We had to adjust the integration tests due to missing assertions in some IntegrationTestUtils methods, see issue #2889.
Before this PR, the tests were successful even though there were failures in the underlying requests. With the zone creation now working, the tests failed since the subsequent requests in the test cases now fail - as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #2505
With PR #2606, we introduced an allow list for the groups in an identity zone. This PR fixes the issue that the creation of a zone fails whenever the allow list does not contain all system scopes ("scim.read/write", "sps.read/write", etc.).
Now, we only create those groups during zone creation that are part of the effectively allowed groups, i.e., all default groups and all groups in the allowlist.