-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrading winston and winston-syslog to current major versions #904
Conversation
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/173793709 The labels on this github issue will be updated when the story is started. |
|
Pull Request Test Coverage Report for Build 4283
💛 - Coveralls |
1b1ccbd
to
13dee54
Compare
Validation on k8s cluster: n-2 is succeeded. |
Validation on k8s cluster: n-1 is succeeded. |
Validation on k8s cluster: n is succeeded. |
1 similar comment
Validation on k8s cluster: n is succeeded. |
I came across this issue winstonjs/winston#1217 recently, I think we need to recheck this PR wrt this issue. |
efde42d
to
e5fc22f
Compare
Validation on k8s cluster: n is succeeded. |
Validation on k8s cluster: n-2 is succeeded. |
Validation on k8s cluster: n-1 is succeeded. |
Validation on k8s cluster: n is succeeded. |
From winstonjs/winston#1408, winstonjs/winston#1217 etc it was concluded that, in v3, to keep the formatting similar to v2 a custom formatter is the best way to go. |
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
+ Coverage 73.03% 73.13% +0.10%
==========================================
Files 45 45
Lines 3968 3968
==========================================
+ Hits 2898 2902 +4
+ Misses 762 758 -4
Partials 308 308 |
No description provided.