Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading winston and winston-syslog to current major versions #904

Merged
merged 3 commits into from
Aug 5, 2020

Conversation

jayeshjk
Copy link
Contributor

No description provided.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/173793709

The labels on this github issue will be updated when the story is started.

@linux-foundation-easycla
Copy link

CLA Check

@coveralls
Copy link

coveralls commented Jul 22, 2020

Pull Request Test Coverage Report for Build 4283

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 81 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.326%

Files with Coverage Reduction New Missed Lines %
core/scheduler-jobs/src/jobs/BackupReaperJob.js 1 96.46%
data-access-layer/docker/src/DockerClient.js 1 59.52%
data-access-layer/eventmesh/src/LockManager.js 1 97.83%
data-access-layer/quota/src/TokenIssuer.js 1 66.67%
applications/operators/src/BaseOperator.js 2 92.17%
core/logging/src/index.js 2 88.89%
data-access-layer/iaas/src/AzureClient.js 2 85.16%
core/scheduler-jobs/src/Scheduler.js 3 98.5%
data-access-layer/iaas/src/CloudProviderClient.js 3 86.23%
applications/operators/src/docker-operator/DockerService.js 5 84.38%
Totals Coverage Status
Change from base Build 4273: 0.02%
Covered Lines: 9345
Relevant Lines: 10104

💛 - Coveralls

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

1 similar comment
@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

@jayeshjk jayeshjk added DO NOT MERGE PipeLine:yet-to-run To be added when pipeline is not run yet, but will be run shortly labels Jul 29, 2020
@jayeshjk
Copy link
Contributor Author

I came across this issue winstonjs/winston#1217 recently, I think we need to recheck this PR wrt this issue.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

@jayeshjk
Copy link
Contributor Author

jayeshjk commented Aug 4, 2020

From winstonjs/winston#1408, winstonjs/winston#1217 etc it was concluded that, in v3, to keep the formatting similar to v2 a custom formatter is the best way to go.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #904 into master will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   73.03%   73.13%   +0.10%     
==========================================
  Files          45       45              
  Lines        3968     3968              
==========================================
+ Hits         2898     2902       +4     
+ Misses        762      758       -4     
  Partials      308      308              

@jayeshjk jayeshjk merged commit 8e1bcaa into master Aug 5, 2020
@jayeshjk jayeshjk deleted the task/winston_upgrade branch October 30, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE PipeLine:yet-to-run To be added when pipeline is not run yet, but will be run shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants