Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize packaging scripts #468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Mar 26, 2024

Description

  • Adds shebang directive for the default shell (used when the directive is missing).
  • Ignore shellcheck warnings related to missing compile.env source files.
  • Removes unnecessary GOPATH export.
  • Removes -mod=vendor flag from go build command, as that flag is on by default in recent versions of Go.

Type of change

  • Maintenance chore
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

- Adds shebang directive for the default shell (used when the directive
  is missing).
- Ignore shellcheck warnings related to missing `compile.env` source
  files.
- Removes unnecessary GOPATH export.
- Removes `-mod=vendor` flag from `go build` command, as that flag is on
  by default in recent versions of Go.
@ctlong ctlong requested a review from a team as a code owner March 26, 2024 21:02
@ctlong
Copy link
Member Author

ctlong commented Mar 26, 2024

⚠️ I have not tested this at all ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pending Review | Discussion
Development

Successfully merging this pull request may close these issues.

None yet

1 participant