Fix app crash events for apps using rolling deployments #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
reviewed
May 14, 2024
- The internal app crash event endpoint assumed that the web process guid == app guid (legacy behavior from the v2->v3 data model migrations) - Rolling deployments create new web processes that have different guids which made it so this endpoint no longer created events associated with the parent app - This change updates the endpoint to make app crash events for the app guid instead of the process guid which should resolve the rolling deployment issue and support crash events for non-web process types Fixes #2587
tcdowney
force-pushed
the
fix-crash-events-for-apps-rolling-deployment-2587
branch
from
daed7a8
to
a90ad04
Compare
philippthun
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the endpoint to make app crash events for the app guid instead of the process guid which should resolve the rolling deployment issue and support crash events for non-web process types.
The internal app crash event endpoint assumed that the web process guid == app guid (legacy behavior from the v2->v3 data model migrations). Rolling deployments create new web processes that have different guids which made it so this endpoint no longer created events associated with the parent app.
Issue: #2587
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests