Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a route destination protocol informs backend #3787

Merged
merged 2 commits into from May 8, 2024

Conversation

tcdowney
Copy link
Member

@tcdowney tcdowney commented May 8, 2024

  • A short explanation of the proposed change:

Updates the RouteDestinationUpdate action to behave like other route update endpoints and notifiy Diego immediately

  • An explanation of the use cases your change solves

Prior to this change users would need to manually restart their app to get a route destination protocol change to take effect.

  • Links to any other associated PRs

Fixes #3687

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

- Updates the RouteDestinationUpdate action to behave like
other route update endpoints and notifiy Diego immediately
- Prior to this change users would need to manually restart their
app to get a route destination protocol change to take effect

Fixes #3687
@tcdowney tcdowney requested a review from philippthun May 8, 2024 16:51
@tcdowney tcdowney merged commit efc2f4f into main May 8, 2024
8 checks passed
@tcdowney tcdowney deleted the route-destination-update-calls-backend-3687 branch May 8, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RouteDestinationUpdate does not trigger a DesiredLRPUpdate call
5 participants