馃Ч Remove MultiJSON, JSON and Yajl (Use Oj instead) #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
force-pushed
the
remove-multi-json
branch
3 times, most recently
from
2ef4b92
to
dea1f84
Compare
philippthun
force-pushed
the
remove-multi-json
branch
from
dea1f84
to
da177c1
Compare
- Use Oj.load and Oj.dump - Oj.load => rescue StandardError - Oj.dump + RestController => mode: :compat - No 'pretty' option anymore
philippthun
force-pushed
the
remove-multi-json
branch
from
da177c1
to
0dc68cf
Compare
philippthun
changed the title
philippthun
changed the title
- Use Oj.load and Oj.dump
philippthun
force-pushed
the
remove-multi-json
branch
from
ffe4f70
to
b0ca889
Compare
philippthun
changed the title
- Use Oj.load and Oj.dump
philippthun
force-pushed
the
remove-multi-json
branch
from
4dcc9b1
to
7fd9b06
Compare
philippthun
force-pushed
the
remove-multi-json
branch
from
2b9f750
to
7fe7aff
Compare
|
CATS have been successfully executed (same configuration as |
svkrieger
reviewed
May 22, 2024
There was a problem hiding this comment.
Overall a very nice change which tidies up our codebase.
Sometimes you removed pretty and added mode: :compat, sometimes not. Is this on purpose? I added comments to some places where I saw that mode is not specified. Later I saw this is in many more places, so probably not an issue if it's not needed.
Very cool that you added a Rubocop rule!
moleske
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oj.loadandOj.dumpOj.load=>rescue StandardErrorOj.dump+RestController=>mode: :compatprettyoption anymoreI have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests