Fix comma-delimited-destination asg error messages #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofffranks
force-pushed
the
fix-asg-error-messages
branch
2 times, most recently
from
fd12f36
to
2a680a0
Compare
geofffranks
force-pushed
the
fix-asg-error-messages
branch
from
2a680a0
to
4ee90a1
Compare
sethboyles
previously approved these changes
May 8, 2024
|
@geofffranks can you resolve the conflicts? Then I'm happy to re-review and merge. |
|
conflicts resolved. 🤞I didn't break anything with the github UI for conflict resolution |
It left some stray whitespace and upset Rubocop 😢 |
geofffranks
force-pushed
the
fix-asg-error-messages
branch
from
89f1dcc
to
11a62c4
Compare
tcdowney
approved these changes
May 10, 2024
|
@tcdowney finally greeeeeeen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error messaging when validating ASG destinations that have comma-delimited destinations.
Previously errors would appear with the message
rules rule number 1 contains invalid destinationrather than something likeRules[0]: destination must be a valid CIDR, IP address, or IP address rangeLinks to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests