Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at dropping vip #3761

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

First pass at dropping vip #3761

wants to merge 1 commit into from

Conversation

moleske
Copy link
Member

@moleske moleske commented Apr 21, 2024

  • migration needed to drop vip, I apparently can't remember how to write migrations in ruby

#3712

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

  • An explanation of the use cases your change solves

  • Links to any other associated PRs

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@tcdowney
Copy link
Member

tcdowney commented May 14, 2024

@moleske regarding the database migration you mentioned. I think you may need to leave the vip_offset column on the routes for some time, otherwise it might cause route creation/update failures during upgrades.

Maybe add a timebomb test to remind us to remove it in the distant future? Example:
7c322ce

@moleske
Copy link
Member Author

moleske commented May 15, 2024

I might skip the time bomb test cause it is unlikely I'll do something when it goes off. Though if others would like it I'll add it. Now that I see cloudfoundry/capi-ci#52 I'll try to actually run cats against (assuming I can actually get an environment)

- still need a migration
@moleske moleske marked this pull request as ready for review May 24, 2024 22:09
@moleske
Copy link
Member Author

moleske commented May 24, 2024

I tried to claim a bosh lite but it seems to think there are none available. I left a message in the capi slack channel asking if I was just doing it wrong. I was able to create a bosh release with cloudfoundry/capi-release#419 but wasn't able to test if it deployed successfully due to the inability to claim a bosh lite. If someone else is able to give a whirl and run cats that would be helpful, or let me know how to correctly claim a bosh lite

@moleske moleske marked this pull request as draft May 25, 2024 01:02
@moleske
Copy link
Member Author

moleske commented May 25, 2024

putting back in draft as I got a bosh lite and cats is failing. wonder if it is cf networking needing this or something else going on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants