Add second order_by parameter, as created_at might not be unique #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
force-pushed
the
secondary-order
branch
3 times, most recently
from
e060044
to
ca99974
Compare
philippthun
changed the title
Resources included by decorators are ordered by 'created_at', which only has a resolution in seconds. This may lead to arbitrary ordering. To ensure a consistent ordering, 'guid', which has already been utilized by the SequelPaginator for secondary ordering, has been added to the decorators as well. Additional database statements aim to return the oldest or newest entries from a selection. For those, 'id' has been added as the second 'order_by' parameter. The specs testing the results of included resources have been improved to ensure a specific ordering by setting a definitive creation date. In some instances, the matcher has been changed from 'match_array' to 'eq', enabling the tests to verify the order of elements.
philippthun
force-pushed
the
secondary-order
branch
from
f7c7cf4
to
42cdeda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources included by decorators are ordered by
created_at, which only has a resolution in seconds. This may lead to arbitrary ordering. To ensure a consistent ordering,guid, which has already been utilized by theSequelPaginatorfor secondary ordering, has been added to the decorators as well.Additional database statements aim to return the oldest or newest entries from a selection. For those,
idhas been added as the secondorder_byparameter.The specs testing the results of included resources have been improved to ensure a specific ordering by setting a definitive creation date. In some instances, the matcher has been changed from
match_arraytoeq, enabling the tests to verify the order of elements.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests