Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit order for user related models #3518

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add explicit order for user related models #3518

wants to merge 1 commit into from

Conversation

johha
Copy link
Contributor

@johha johha commented Nov 20, 2023 •
edited

In some cases it might happen that the returned results have the wrong order, e.g. when running cc with postgres 10 and special foreign key indexes (commit: 5bb3fe9 / #3509)

  • Links to any other associated PRs

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@johha
Add explicit order for user related models
a86b3b1 
In some cases it might happen that the returned results have the wrong
order, e.g. when running cc with postgres 10 and special foreign key
indexes (commit: 5bb3fe9 /  #3509)

This commit adds a '.order' for all user related models to ensure the
correct order.
@johha johha marked this pull request as ready for review November 20, 2023 14:16
@johha johha mentioned this pull request Nov 20, 2023
Merged
5 tasks
@johha johha marked this pull request as draft November 20, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johha