Optionally overwrite timeout for Logcache::Client #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout used for the Logcache GRPC client was hard-coded to 250 seconds. With this change the timeout can be (optionally) configured to a different value. Running "cf push" results in requests to /v3/processes/:guid/stats. But in case Logcache is unavailable, "cf push" can actually continue/succeed without showing the requested data. The default timeout resulted in long-running requests without adding much value.
moleske
reviewed
Jul 6, 2022
There was a problem hiding this comment.
This configuration needs a capi-release pr to go with it
-michael & @sethboyles
| @@ -6,7 +6,9 @@ class Client | |||
| MAX_LIMIT = 1000 | |||
| DEFAULT_LIMIT = 100 | |||
|
|
|||
| def initialize(host:, port:, client_ca_path:, client_cert_path:, client_key_path:, tls_subject_name:) | |||
| def initialize(host:, port:, timeout:, client_ca_path:, client_cert_path:, client_key_path:, tls_subject_name:) | |||
| timeout ||= 250 | |||
There was a problem hiding this comment.
This default should be specified in capi-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout used for the Logcache GRPC client was hard-coded to 250 seconds. With this change the timeout can be (optionally) configured to a different value.
Running "cf push" results in requests to
/v3/processes/:guid/stats. But in case Logcache is unavailable, "cf push" can actually continue/succeed without showing the requested data. The default timeout resulted in long-running requests without adding much value.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests