Prevent race conditions when cancelling service operations #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
force-pushed
the
prevent-race-conditions-when-cancelling-service-operations
branch
14 times, most recently
from
5a44b7d
to
3c98a32
Compare
The CreateBindingAsyncJob processes service credential bindings, service keys and service route bindings. There can be race conditions when a delete has been successful just before the polling times out or the entire job expires. Add tests to the 'create binding job' shared examples to simulate the scenarios outlined above. The resource being gone results in a Sequel::NoExistingObject exception that is now caught and logged. Furthermore the database resource is only loaded once per job execution (resulting in less database queries) and reloaded when needed.
philippthun
force-pushed
the
prevent-race-conditions-when-cancelling-service-operations
branch
from
3c98a32
to
e5be915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip...
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests