fix(log_cache_client): Only process HTTPStartStopEvents with peerType client #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvestre
added
the
allow-acceptance-tests
# Issue The CI job [upgrade-test] requires the current manifest to be able to deploy the previous stable release. The removal of `use_buildin_mode: false` broke this # Fix Restore `use_buildin_mode: false` until v13 is the previous stable release. [upgrade-test]: https://concourse.app-runtime-interfaces.ci.cloudfoundry.org/teams/app-autoscaler/pipelines/app-autoscaler-release/jobs/upgrade-test
# Issue To access our OSS dev environment's BOSH directory one would have to always execute the `bbl print-env` command. # Fix Automatically execute it on entering the directory if possible.
…gregator shard # Issue Due to different deployments in our CI enviroment all setting the same loggrator nozzle shard, logs and metrics generated during a CI run would get distributed across all `metricsgateway`s. This broke the assumption that a deployments get a copy of all logs and metrics and lead to acceptance test failures. # Fix Added an ops file to make the shard ids unique by appending the BOSH deployment name.
Add the `logcache` CLI plugin, which offers e.g. `cf query` to make PromQL queries to the logcache. Add the `hey` command which can be used to generate requests on an HTTP endpoint.
silvestre
force-pushed
the
skip-throughput-and-acceptance-in-ci
branch
from
340c688
to
457d914
Compare
silvestre
changed the title
throughput and responsetime acceptance tests in loggregator mode
silvestre
force-pushed
the
skip-throughput-and-acceptance-in-ci
branch
from
457d914
to
4be7de5
Compare
… client # Issue `HTTPStartStop` events with `peerType` `Server` would be counted against instance `0` and thus duplicate the number of requests counted by the App Autoscaler. # Fix Only process `HTTPStartStop` events with `peerType` `Client`, as they contain the app instance index in the `instanceIndex` field. # Note This is the same issue already fixed for loggregator in c2479e2
silvestre
force-pushed
the
skip-throughput-and-acceptance-in-ci
branch
from
4be7de5
to
8c50ffa
Compare
|
salzmannsusan
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
HTTPStartStopevents withpeerTypeServerwould be counted againstinstance
0and thus duplicate the number of requests counted by theApp Autoscaler.
Fix
Only process
HTTPStartStopevents withpeerTypeClient, as theycontain the app instance index in the
instanceIndexfield.Note
This is the same issue already fixed for loggregator in c2479e2