feat(scalingengine): Support app label to disable autoscaling #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvestre
changed the title
silvestre
changed the title
silvestre
force-pushed
the
read-annotations
branch
from
8a10c47
to
7097040
Compare
|
silvestre
added
the
allow-acceptance-tests
silvestre
force-pushed
the
read-annotations
branch
2 times, most recently
from
56b6d12
to
cf62391
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
silvestre
changed the title
silvestre
force-pushed
the
read-annotations
branch
2 times, most recently
from
145fff4
to
eeb9ec5
Compare
|
The main commit is 84b078f - the other changes are unrelated and could be split out to their own PRs if necessary. |
silvestre
force-pushed
the
read-annotations
branch
2 times, most recently
from
9a36249
to
d52ddc8
Compare
# Issue `uaac` was missing in the devbox. The version installed in the `Makefile` could get out of date with the Ruby version and break. # Fix Add `uaac` in `local-flake`. # Note Having the gemset nix in the flake directory seem ugly, but moving it to a subdirectory did not work on first try.
# Background During DevOps tasks such as deployments or periods where manual scaling is required (e.g., in an outage situation) a simple and quick way to disable autoscaling might be helpful that does not involve editing or deleting the autoscaling policy. # Details This PR introduces a label `app-autoscaler.cloudfoundry.org/disable-autoscaling`. If it is set on an app the app-autoscaler will not scale it, even if a scaling policy is active.
silvestre
force-pushed
the
read-annotations
branch
from
d52ddc8
to
b34e280
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
During DevOps tasks such as deployments or periods where manual
scaling is required (e.g., in an outage situation) a simple and
quick way to disable autoscaling might be helpful that does not
involve editing or deleting the autoscaling policy.
Details
This PR introduces a label
app-autoscaler.cloudfoundry.org/disable-autoscaling.If it is set on an app the app-autoscaler will not
scale it, even if a scaling policy is active.