Create liveliness endpoint #1506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalan316
force-pushed
the
create-liveliness-endpoint
branch
2 times, most recently
from
04bc7db
to
445429d
Compare
joergdw
force-pushed
the
create-liveliness-endpoint
branch
from
fda104a
to
472375b
Compare
asalan316
force-pushed
the
create-liveliness-endpoint
branch
from
478b82a
to
be9db41
Compare
joergdw
force-pushed
the
create-liveliness-endpoint
branch
from
be9db41
to
44d0f76
Compare
joergdw
added
the
allow-acceptance-tests
joergdw
force-pushed
the
create-liveliness-endpoint
branch
12 times, most recently
from
d8fabe2
to
d484f7b
Compare
joergdw
force-pushed
the
create-liveliness-endpoint
branch
5 times, most recently
from
de0e65d
to
8498b9b
Compare
asalan316
force-pushed
the
create-liveliness-endpoint
branch
4 times, most recently
from
0270ec1
to
2865f60
Compare
asalan316
force-pushed
the
create-liveliness-endpoint
branch
6 times, most recently
from
12aec5f
to
7aff4d1
Compare
start health server on defined ports (Port 0 is not allowed)
asalan316
force-pushed
the
create-liveliness-endpoint
branch
from
7aff4d1
to
f09bc70
Compare
…alth/liveness) to avoid breaking changes
asalan316
force-pushed
the
create-liveliness-endpoint
branch
from
fbd69ea
to
f853498
Compare
joergdw
requested changes
May 25, 2023
...uler/src/main/java/org/cloudfoundry/autoscaler/scheduler/conf/HealthServerConfiguration.java
Show resolved
Hide resolved
...uler/src/main/java/org/cloudfoundry/autoscaler/scheduler/conf/HealthServerConfiguration.java
Outdated
Show resolved
Hide resolved
...uler/src/main/java/org/cloudfoundry/autoscaler/scheduler/rest/BasicAuthenticationFilter.java
Show resolved
Hide resolved
...uler/src/main/java/org/cloudfoundry/autoscaler/scheduler/conf/HealthServerConfiguration.java
Outdated
Show resolved
Hide resolved
...uler/src/main/java/org/cloudfoundry/autoscaler/scheduler/rest/BasicAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
...uler/src/main/java/org/cloudfoundry/autoscaler/scheduler/rest/BasicAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
| if (ObjectUtils.isEmpty(unprotectedEndpointsConfig)) { // health endpoints are authorized | ||
| isUserAuthenticatedOrSendError(chain, httpRequest, httpResponse); | ||
| } else if (!ObjectUtils.isEmpty(unprotectedEndpointsConfig)) { | ||
| Map<String, Boolean> validateMap = checkValidEndpoints(unprotectedEndpointsConfig); |
There was a problem hiding this comment.
- I think a config-check should rather go into the config-class itself (see former comments).
- The name may be misleading. I rather understand it as a
nonExistingEndpoints. - Why do we need a boolean? Isn't pure existence enough? Then a set (as mentioned above) would be more appropriate.
There was a problem hiding this comment.
As an additional note, when I think about what we want to do: It would simplify a lot to have a function with the following signature in the class HealthServerConfiguration:
public boolean endpointIsUnprotected(<Some type> endpoint) {…It is then reusable here! And as it will be quite performant, this simplification would then make as well obvious that we do not need the special case treatment in the lines 58-59 of the current implementation.
...uler/src/main/java/org/cloudfoundry/autoscaler/scheduler/rest/BasicAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
src/scheduler/src/main/java/org/cloudfoundry/autoscaler/scheduler/rest/MultiPortFilter.java
Outdated
Show resolved
Hide resolved
src/scheduler/src/test/java/org/cloudfoundry/autoscaler/scheduler/util/HealthUtils.java
Outdated
Show resolved
Hide resolved
…ler/rest/BasicAuthenticationFilter.java Co-authored-by: joergdw <joerg.weisbarth@sap.com>
…ler/conf/HealthServerConfiguration.java Co-authored-by: joergdw <joerg.weisbarth@sap.com>
…ler/conf/HealthServerConfiguration.java Co-authored-by: joergdw <joerg.weisbarth@sap.com>
asalan316
force-pushed
the
create-liveliness-endpoint
branch
5 times, most recently
from
6a0c834
to
73cf734
Compare
asalan316
force-pushed
the
create-liveliness-endpoint
branch
from
73cf734
to
87416bc
Compare
asalan316
force-pushed
the
create-liveliness-endpoint
branch
from
4180e19
to
145d426
Compare
asalan316
force-pushed
the
create-liveliness-endpoint
branch
from
5c84978
to
e237065
Compare
asalan316
force-pushed
the
create-liveliness-endpoint
branch
from
e237065
to
0a8b9db
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces new
/health/liveness endpoint, allowing users to check the health of the individual servicesThe response
{"overall_status":"UP","checks":[]}Also, the following existing endpoints are now moved to the new paths
Golang Microservices
Scheduler Microservice
By default, all health routes are protected with basic auth.
However, routes can be configured to be unprotected by using the configuration
autoscaler.apiserver.health.unprotected_endpoints