Trait for async API clients #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Currently, futures/async fns aren't supported in traits, and won't be for a while. | ||
| // So unlike ApiClient/HttpApiClient, there's no trait with the request method. | ||
| pub async fn request<ResultType, QueryType, BodyType>( | ||
| #[async_trait] |
There was a problem hiding this comment.
I wonder if the language will ever support this directly - I wasn't able to find anything in the rust-lang issue tracker.
There was a problem hiding this comment.
The async book mentions it, and this article explains why it's hard. There's two features that probably have to land before async traits are properly supported: 1 and 2
EverlastingBugstopper
approved these changes
Jan 10, 2020
ashleymichal
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Note this adds a slight bit of overhead for using the async client, because of
dyn, which has to box the concrete type and put it on the heap (I think). But that's going to be dominated by the cost of the network calls and possibly the serializing/deserializing JSON