[Workers] New Python Workers Example #14569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megaconfidence
requested review from
GregBrimble,
irvinebroque,
WalshyDev,
deadlypants1973 and
a team
as code owners
Deploying cloudflare-docs with
|
| Latest commit: |
c017f51
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23e930d4.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://docs-py-examples2.cloudflare-docs-7ou.pages.dev |
|
Please can you take a look @hoodmane. Thanks! |
hoodmane
reviewed
May 18, 2024
| return _to_js(x, dict_converter=Object.fromEntries) | ||
|
|
||
| async def on_fetch(request): | ||
| cors_headers = { |
There was a problem hiding this comment.
Could you move most of the body of on_fetch to top level definitions?
e.g. cors_headers, api_url, raw_html_response, handle_request, handle_options? As far as I can tell none of them are closing over per-request data so it's nice to have them in the top level.
There was a problem hiding this comment.
That makes sense, but I'm thinking of leaving it in to keep the examples consistent across languages
hoodmane
reviewed
May 18, 2024
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
|
Thanks @megaconfidence! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new example for: