[Pages] Update Astro guide for new adapter #14535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnmsl
requested review from
IgorMinar,
dario-piotrowicz,
jculvey,
deadlypants1973 and
a team
as code owners
dario-piotrowicz
approved these changes
May 13, 2024
There was a problem hiding this comment.
@jnmsl Thanks a lot for the PR! it looks great! 😄 ❤️
I've just left one minor comment other than that it should be good to go.
pedrosousa
reviewed
May 13, 2024
| // use `AdvancedRuntime<ENV>` for advance runtime mode | ||
| // use `DirectoryRuntime<ENV>` for directory runtime mode | ||
| type Runtime = import("@astrojs/cloudflare").AdvancedRuntime<ENV>; | ||
| type Runtime = import("@astrojs/cloudflare").Runtime<ENV>; |
There was a problem hiding this comment.
Nit: We should probably also update the comments above this line.
There was a problem hiding this comment.
Based on the updates from the v10 adapter release, where the mode options have been deprecated and the adapter now defaults to 'advanced' mode, the comment could be:
// use a default runtime configuration (advanced mode).
Co-authored-by: Dario Piotrowicz <dario.piotrowicz@gmail.com>
kodster28
approved these changes
May 16, 2024
|
thanks for the contribution, @jnmsl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the deployment documentation for Astro projects on Cloudflare Pages to align with the recent v10 changes in the @astrojs/cloudflare adapter.
Changes: