Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workers AI] Huggingface chat ui template notes #14488

Merged
merged 5 commits into from
May 30, 2024
Merged

[Workers AI] Huggingface chat ui template notes #14488

merged 5 commits into from
May 30, 2024
+47 −0

Conversation

kodster28
Copy link
Contributor

PCX-10717

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented May 8, 2024 •
edited

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5ae5094
Status: ✅  Deploy successful!
Preview URL: https://2e24f997.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://hugging-face-template.cloudflare-docs-7ou.pages.dev

View logs

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workers-ai/configuration/hugging-face-chat-ui/ https://hugging-face-template.cloudflare-docs-7ou.pages.dev/workers-ai/configuration/hugging-face-chat-ui/

@kodster28
Copy link
Contributor Author

Question for @craigsdennis / @mchenco ... based off their endpoint schema:

  1. If I'm reading this line correctly, it sounds like their example is actually incorrect and might need to be updated?
  2. If ^^^ is correct, does that mean that we should also be specifying the model parameter w/in the endpoint configuration?
  3. Correct assumption that this only works with models prefixed with @hf, think so based on their code.

@kodster28 kodster28 mentioned this pull request May 29, 2024
Open
@kodster28
Copy link
Contributor Author

Asking for clarification in huggingface/chat-ui#1220

@kodster28 @crwaters16
Apply suggestions from code review
5ae5094 
Co-authored-by: Claire W <78226508+crwaters16@users.noreply.github.com>
@kodster28 kodster28 merged commit cb3f6c4 into production May 30, 2024
7 checks passed
@kodster28 kodster28 deleted the hugging-face-template branch May 30, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwaters16 crwaters16 crwaters16 approved these changes

@rita3ko rita3ko Awaiting requested review from rita3ko rita3ko is a code owner

@pdwittig pdwittig Awaiting requested review from pdwittig pdwittig is a code owner

@deadlypants1973 deadlypants1973 Awaiting requested review from deadlypants1973

@craigsdennis craigsdennis Awaiting requested review from craigsdennis craigsdennis is a code owner

@markdembo markdembo Awaiting requested review from markdembo markdembo is a code owner

@mchenco mchenco Awaiting requested review from mchenco mchenco is a code owner

Assignees

@pdwittig pdwittig

@rita3ko rita3ko

@craigsdennis craigsdennis

@mchenco mchenco

@markdembo markdembo

@deadlypants1973 deadlypants1973

Labels
product:workers-ai size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kodster28 @crwaters16 @pdwittig @rita3ko @craigsdennis @mchenco @markdembo @deadlypants1973