New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid jest#13535 and planttheidea/fast-equals#91 #515
Comments
PSanetra
added a commit
to PSanetra/cloudevents-sdk-javascript
that referenced
this issue
Oct 31, 2022
….keys() (cloudevents#515) Signed-off-by: Philip Sanetra <code@psanetra.de>
PSanetra
added a commit
to PSanetra/cloudevents-sdk-javascript
that referenced
this issue
Oct 31, 2022
….keys() (cloudevents#515) Signed-off-by: Philip Sanetra <code@psanetra.de>
PSanetra
added a commit
to PSanetra/cloudevents-sdk-javascript
that referenced
this issue
Oct 31, 2022
….keys() (cloudevents#515) Signed-off-by: Philip Sanetra <code@psanetra.de>
PSanetra
added a commit
to PSanetra/cloudevents-sdk-javascript
that referenced
this issue
Oct 31, 2022
….keys() (cloudevents#515) Signed-off-by: Philip Sanetra <code@psanetra.de>
PSanetra
added a commit
to PSanetra/cloudevents-sdk-javascript
that referenced
this issue
Nov 1, 2022
….keys() (cloudevents#515) Signed-off-by: Philip Sanetra <code@psanetra.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
CloudEvent
class instances are at the moment not comparable using some popular libraries. Instances might be considered equal although they are not equal.See the following issues:
Steps to Reproduce
expect(...).toStrictEqual(...)
of jest and tocircularDeepEqual(...)
of the fast-equals libraryExpected Behavior
Both instances should not be considered equal using those libraries.
How to fix
I think the best way to avoid this issue is to avoid using private javascript fields and use private Typescript fields instead.
The text was updated successfully, but these errors were encountered: