Skip to content

feat: use generic type for CloudEvent data #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2021

Conversation

lance
Copy link
Member

@lance lance commented Nov 20, 2021

Instead of using a big union of types, use a generic type for event data.

Fixes: #445

Signed-off-by: Lance Ball lball@redhat.com

Instead of using a big union of types, use a generic type for event data.

Fixes: cloudevents#445

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance added the type/enhancement New feature or request label Nov 20, 2021
@lance lance requested a review from a team November 20, 2021 16:33
Signed-off-by: Lance Ball <lball@redhat.com>
@lance
Copy link
Member Author

lance commented Nov 24, 2021

@matthewrobertson thank you for the excellent feedback. I have incorporated your suggestions, but do have a couple of questions inline.

Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
@matthewrobertson
Copy link

LGTM

@lance
Copy link
Member Author

lance commented Nov 25, 2021

@grant and @lholmquist - when you guys get a chance, a quick review here from one of you next week would be appreciated. Thanks!

Copy link
Contributor

@lholmquist lholmquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i needed to do a little reading up on TS generics, but LGTM

@lance lance merged commit d941e2d into cloudevents:main Nov 29, 2021
@lance lance deleted the lance/generic-event-data-type branch November 29, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CloudEvent type should be generic
3 participants