-
Notifications
You must be signed in to change notification settings - Fork 70
feat: use generic type for CloudEvent data #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instead of using a big union of types, use a generic type for event data. Fixes: cloudevents#445 Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
@matthewrobertson thank you for the excellent feedback. I have incorporated your suggestions, but do have a couple of questions inline. |
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
LGTM |
@grant and @lholmquist - when you guys get a chance, a quick review here from one of you next week would be appreciated. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i needed to do a little reading up on TS generics, but LGTM
Instead of using a big union of types, use a generic type for event data.
Fixes: #445
Signed-off-by: Lance Ball lball@redhat.com