Upgrade nodejs runtime to 16.x (v2 branch) #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbp
force-pushed
the
upgrade-nodejs-runtime
branch
from
85fcc7b
to
6a0f1c6
Compare
mbp
changed the title
|
@hupe1980 sorry to bother :-) Is it possible that you could take a look? |
|
Friendly reminder @hupe1980. Now only 5 months for end of support for Node.js 14.x. |
added 5 commits
March 21, 2024 15:50
- Updated Lerna to the latest version. - Updated Webpack dependency in cdkdx which has an SSL security issue hupe1980/cdkdx#22. - Updated ClamAV version for Ubuntu run in Docker. Version `0.103.11-1.el7` is no longer available. - Added build instructions to README. Build results: ``` Lerna (powered by Nx) Successfully ran target build for 45 projects (2m) ✨ Done in 113.17s. ``` Test results: ``` Test Suites: 42 passed, 42 total Tests: 106 passed, 106 total Snapshots: 64 passed, 64 total Time: 7.664 s Ran all test suites in 27 projects. ✨ Done in 10.13s. ```
- Issue reported in aws/jsii#3505. - Upstream https://hub.docker.com/r/jsii/superchain recommends the `1-bullseye-slim` version.
Docker is required to build some of the packages. Must grant permissions to the socket.
|
Hi @mbp! Just wanted to know if you are available to fix some comments for this PR? There are some errors if run as is. Can you rebase your branch from |
- Fix dependency versionsing. Must use the carrot `^` to ensure users can use any CDK version higher than then over tested here. - Some constant enum names have changed in the newer versions. - Granting permissions now require an IAM role instead of the handler. - CloudFront distribution interface have changed.
|
@kadishmal sorry, I am not available to do the changes. I had to stop using this project because of lack of updates. |
|
@mbp, sure, I've made changes to fix the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 16.x runtime has been available since May 2022: https://aws.amazon.com/blogs/compute/node-js-16-x-runtime-now-available-in-aws-lambda/
Node.js 14.x support is ending in 6 months: https://github.com/nodejs/release#release-schedule
Node.js 12.x support has already ended.
In this PR, I update all Lambda functions to use 16.x runtime. I also had to upgrade aws-cdk-lib minimum dependency to 2.28.0, since this version adds NODEJS_16_X on CustomResourceProviderRuntime.