Create and delete vhosts #14
Conversation
baelter
changed the title
| headers = HTTP::Headers{"Content-Type" => "application/json"} | ||
|
|
||
| begin | ||
| if name = options["remove"]? | ||
| resp = HTTP::Client.delete "#{options["host"]}/api/#{entity}", headers, name.to_s | ||
| resp = HTTP::Client.delete "#{options["host"]}/api/#{entity}", headers, { name: name.to_s, vhost: options["vhost"]? }.to_json |
There was a problem hiding this comment.
shouldn't vhost and name be in the path? DELETE /api/vhost/exchange/my-exchange ?
There was a problem hiding this comment.
Sure, I think we should use kemal for route parsing etc. then. I'll save that improvement for another branch
src/avalanchemq/server.cr
Outdated
| save_server_definitions | ||
| end | ||
|
|
||
| private def load_server_definitions |
There was a problem hiding this comment.
does server_ have to be in the name? when we are in the Server class?
src/avalanchemq/http_server.cr
Outdated
| def delete(context) | ||
| case context.request.path | ||
| when "/api/policies" | ||
| body = JSON.parse(context.request.body.not_nil!) |
There was a problem hiding this comment.
are we sure that body is never nil here?
src/avalanchemq/server.cr
Outdated
| data.each do |k, v| | ||
| case k | ||
| when "vhosts" | ||
| v.each { |vhost| create_vhost(vhost["name"].as_s, false) } |
There was a problem hiding this comment.
in create_vhost we call save_server_definitions that overwrites the file we're currently reading from. You probably want to pass a flag to create_vhost, or not call save_defintions from create_vhost at all, instead always do it outside the create/delete-vhost methods
src/avalanchemq/vhost.cr
Outdated
| @@ -17,14 +17,16 @@ module AvalancheMQ | |||
| @wfile : MessageFile | |||
| @log : Logger | |||
|
|
|||
| def initialize(@name : String, @server_data_dir : String, server_log : Logger) | |||
| def initialize(@name : String, @server_data_dir : String, server_log : Logger, clean = false) | |||
There was a problem hiding this comment.
could clean be ambiguous? is truncate or wipe better? or instead of passing a flag, should we only allow deleting it as a mean of wiping it?
carlhoerberg
force-pushed
the
c-rm-vhosts
branch
from
1cbe478
to
2904ff5
Compare
No description provided.