Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query routes using host filter so no pagination is needed #2334

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

apburnes
Copy link
Contributor

@apburnes apburnes commented Sep 12, 2019

Description

When a user delete's a site, a query for the route guid is need to delete the route. When the route results were not listed in the first page, the route query was not paginating through the next list. To fix this, we now query the routes based on the host name.

Acceptance Criteria:

  • Query routes using the host filter to avoid pagination
  • Allow winston logger to parse object errors see issue.

@apburnes apburnes merged commit b35308d into staging Sep 13, 2019
@davemcorwin davemcorwin deleted the apburnes/fix-route-delete branch April 21, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants