Waf labels #1637
Closed
Waf labels #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdboyd
reviewed
Apr 18, 2024
| single_header { | ||
| name = "host" | ||
| dynamic "rule" { | ||
| for_each = var.waf_hostnames_0 |
There was a problem hiding this comment.
Suggested change
| for_each = var.waf_hostnames_0 | |
| for_each = var.waf_drop_logs_hostnames |
Can we rename to remove the 0 index since this is a list of values? And rename to make the use more obvious?
There was a problem hiding this comment.
let me work on that
markdboyd
reviewed
Apr 18, 2024
| statement { | ||
| or_statement { | ||
| dynamic "statement" { | ||
| for_each = var.waf_hostnames_0 |
There was a problem hiding this comment.
Wait, is the nested for_each intentional here? With this code, I'd expect we'd get a separate rule for each hostname and three separate statements (combined with OR) within each rule
If the goal is to make the rules totally optional based on whether there are values in the variable, then rule needs to be dynamic. If the goal is just to have a dynamic set of statements within a rule that is always deployment, then statement here is the only thing that needs to be dynamic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Notes
This change sets a label at the WAF layer to all internal logstash traffic so we can drop logging that specific WAF traffic to CloudWatch. We also then forward that traffic to a specific router pool
security considerations
n/a