Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix WAF rules to have unique metric names #1636

Merged
merged 2 commits into from Apr 17, 2024
Merged

fix WAF rules to have unique metric names #1636

merged 2 commits into from Apr 17, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • Make sure our WAF rules have different metric names. Right now, multiple rules are being aggregated with the same metric name, which doesn't allow us to see the specific request counts per rule

security considerations

Improves our visibility into WAF rule effectiveness

@markdboyd markdboyd requested a review from a team April 17, 2024 19:22
rcgottlieb
rcgottlieb previously approved these changes Apr 17, 2024
View reviewed changes
@markdboyd markdboyd enabled auto-merge (squash) April 17, 2024 19:28
@markdboyd markdboyd merged commit d395837 into main Apr 17, 2024
2 checks passed
@markdboyd markdboyd deleted the fix-waf-rule-metric-names branch April 17, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcgottlieb rcgottlieb rcgottlieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markdboyd @rcgottlieb