Introduce custom-face-1
/custom-face-2
facility
#3646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
DSLs and libraries with special semantics aren't uncommon in the Clojure world.
Users of those may want some extra highlighting rules, with different faces, that apply to just those DSLs.
Those extra faces allow to:
CIDER by default gives a relatively small palette of faces to be possibly applied, so stuff either won't get any particular font-locking, or the applied font-locking will overlap with Clojure font-locking (e.g. N different things all use
font-lock-variable-name-face
), hindering the desired distinction.Changes
Introduce two new faces and two customizable 'categorizers' that when set, decide whether a given symbol should use one of the custom faces.
Example
The user would simply use something like:
And then one's theme can be customized to use the produced faces:
Status
Generally ready and functional, except for the addition of a user manual + changelog entry.
I also plan to provide a little more metadata from cider-nrepl (in an efficient manner).
Tweaks welcome.
Cheers - V