Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote cider-jack-in breaks with cider-enrich-classpath: No such file or directory #3567

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Remote cider-jack-in breaks with cider-enrich-classpath: No such file or directory #3567

wants to merge 6 commits into from

Commits on Nov 16, 2023

  1. Fix remote cider-jack-in-clj breaking with cider-enrich-classpath c… 

    …lojure-emacs#3567

Fixes `cider-jack-in-clj` in tramp buffers throwing:
```
Could not start nREPL server: %s (%S)
bash: /remote/path/to/cider/clojure.sh: No such file or directory\n" "exited abnormally with code 127")
```
in cases where cider is not installed in the same directory on the
remote.

To fix this, we create temporary copy of the enrich-classpath script
named `.cider__<clojure.sh|lein.sh>__<random>` on the remote before
starting the server. The possible locations of the script are, in this
order:
- tramp-tempdir (usually "/tmp")
- clojure-project-dirj
- default-directory

If the script can't be created for any reason, the server is started with
`cider-enrich-classpath` set to nil.

Note: the temporary script will remove itself after use, but stick around when
something goes wrong before the remote process is started.
    @adrech
    adrech committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    44622e5 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @adrech
    adrech committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    90010d7 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary Emacs 29+ setting 

    `auto-save-visited-mode` will not create any tempfiles anyways, but only
save the current file.
    @adrech
    adrech committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    fd4562b View commit details
    Browse the repository at this point in the history

  4. Fix with-demoted-errors message not containing format string

    @adrech
    adrech committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    881df67 View commit details
    Browse the repository at this point in the history

  5. Don't try to get the script path in cider--enriched-cmd-p 

    We don't need it (yet) and Emacs 26 does not support
`split-string-shell-command`.
Don't want to fiddle with shell-quoting unless really necessary.
    @adrech
    adrech committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    c663ee9 View commit details
    Browse the repository at this point in the history

  6. Try to appease windows (shell-quoting)

    @adrech
    adrech committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    8183c2b View commit details
    Browse the repository at this point in the history