Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce cider-start-server command #3555

Merged
merged 22 commits into from Oct 31, 2023
Merged

Conversation

behrica
Copy link
Contributor

@behrica behrica commented Oct 26, 2023

Split cider-jack-in in two and therefore obtain interactive function cider-start-server,
which starts the nrpel server without trying to connect afterwards

see here:
https://clojurians.slack.com/archives/C0617A8PQ/p1698268379712609?thread_ts=1698268132.937489&cid=C0617A8PQ


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • [x ] The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • [ x] All tests are passing (eldev test)
  • [ ]x All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

by  splitting cider-jack-in
Copy link
Member

@vemv vemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Can you confirm that this change does accomplish your end goal?

cider.el Outdated Show resolved Hide resolved
cider.el Show resolved Hide resolved
Co-authored-by: vemv <vemv@users.noreply.github.com>
@behrica
Copy link
Contributor Author

behrica commented Oct 26, 2023

Looking good!

Can you confirm that this change does accomplish your end goal?

To a large extend.
I can start now the nREPL server without bothering with the dependencies.

And then an easy cider connect using host and port I know anyhow (as I fix the port in order to have tunneling working)

Something similar could be reached as well by:
#3519

CHANGELOG.md Outdated Show resolved Hide resolved
cider.el Outdated Show resolved Hide resolved
cider.el Outdated Show resolved Hide resolved
doc/modules/ROOT/pages/basics/up_and_running.adoc Outdated Show resolved Hide resolved
cider.el Outdated Show resolved Hide resolved
behrica and others added 3 commits October 28, 2023 10:44
Co-authored-by: vemv <vemv@users.noreply.github.com>
Co-authored-by: vemv <vemv@users.noreply.github.com>
addressing PR comments
@behrica behrica requested review from vemv October 28, 2023 08:49
cider.el Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
cider.el Outdated Show resolved Hide resolved
from PR review
to cider--start-nrepl-server-with-callback
@behrica behrica requested a review from bbatsov October 28, 2023 17:19
cider.el Outdated Show resolved Hide resolved
cider.el Outdated Show resolved Hide resolved
@bbatsov
Copy link
Member

bbatsov commented Oct 30, 2023

I think you can also add some keybinding for this in the jack-in keymap and mention in the relevant command menu.

regrading key binding and &optional
@behrica behrica requested a review from bbatsov October 30, 2023 20:44
@behrica
Copy link
Contributor Author

behrica commented Oct 30, 2023

If / when #3563 get decided on and this is merged, we could slightly change the docu again.
Because a user has then basically three options when working with remote hosts, in decreasing order of comfort
and increasing guaranty of success and flexibility.

  1. Rely on cider-jack-in and its configurations to heuristically do the correct thing for start and connect
  2. cider-nrepl-start-server followed by cider-connect with some heuristic to detect server and tunnel ports
  3. Manual start of nREPL , ev. manual port tunneling, and cider-connect

cider.el Outdated Show resolved Hide resolved
@behrica behrica requested a review from bbatsov October 31, 2023 10:51
cider.el Outdated Show resolved Hide resolved
cider.el Outdated Show resolved Hide resolved
@behrica behrica requested a review from bbatsov October 31, 2023 13:31
cider.el Outdated Show resolved Hide resolved
cider.el Outdated Show resolved Hide resolved
@behrica behrica requested a review from bbatsov October 31, 2023 15:08
@bbatsov bbatsov merged commit 71a8d67 into clojure-emacs:master Oct 31, 2023
34 of 35 checks passed
@bbatsov
Copy link
Member

bbatsov commented Oct 31, 2023

Thanks!

@behrica behrica deleted the splitJackIn branch October 31, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants