Issue 176: Add support for :extend-via-metadata in defprotocol #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALai57
commented
Oct 18, 2022
| @@ -11,6 +11,8 @@ | |||
| (is (= (count (marginalia.parser/parse "(ns test)\n\"some string\"")) 1)) | |||
| (is (= (count (marginalia.parser/parse "(ns test (:require [marginalia.parser :as parser]))\n(defn foo [] ::parser/foo)")) 1))) | |||
|
|
|||
| (deftest extend-via-metadata | |||
| (is (marginalia.parser/parse "(ns test)\n(defprotocol Foo \"Does a Foo\" :extend-via-metadata true (do-foo! [_ opts] \"Foo!\"))"))) | |||
There was a problem hiding this comment.
The old behavior is that this would throw an exception when :extend-via-metadata was present, so I thought that checking that it returns a truthy value (and doesn't throw) was a sufficient test.
|
Wow, sorry that this PR has languished for so long. I can merge, but do not have the ability to make a release. Thank you, belatedly, for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solution for the problem mentioned in #176 - that Clojure 1.10 added support for options in the
defprotocolmacro https://clojure.org/reference/protocols#_extend_via_metadata. Currently, the supported options are limited to:extend-via-metadata, which adds two forms before the actual method definitions.This PR checks to see if the
:extend-via-metadatakey is present in thedefprotocolbody, and accounts for its presence or absence.