Dx topic replay #53
Dx topic replay #53
Conversation
There was a problem hiding this comment.
Added methods to ensure availability when publishing events.
There was a problem hiding this comment.
This event doesn't use any methods from GroupMemberEvent AND does not publish a DX messages so I've changed it to inherit from GroupEvent.
There was a problem hiding this comment.
I'm not sure what's going on with this change-- it looks like the interface that is being implemented (PublishableApplicationEvent) is no longer used, but two other un-used imports are brought in... And why remove the getPublishableMessage part?
There was a problem hiding this comment.
OK, maybe I understand that the publishable message gets pushed down to GenesAdded. Should this implement PublishableEvent instead of PublishableApplication event, then?
There was a problem hiding this comment.
The idea was that the parent GeneEvent should not implement any methods related to publishing events since not all subclasses will necessarily be Publishable events. I made these changes before I realized GeneAddedApproved and GeneRemovedApproved were never actually used anywhere (and subsequently removed), but I still believe this is the right thing to do b/c GeneAdded and GeneRemoved actually require different implementations of getPublishableMessage. And we don't know whether future GeneEvent descendants will all be publishable.
So far all GeneEvents are PublishableApplicationEvents and should implement that interface.
I admit this is more byzantine than current TJ is particularly thrilled about.
…liation id updated..
|
rebased (again) removing some duplicated commits, dropping the changes that were reverted later and moving them instead to the |
… facilitate auditing.
Work required for replaying DX gpm-general-events with corrections.
Note that this PR is compared to L10 for ease of review.