Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gzip compression on file writing #129

Closed
theferrit32 opened this issue Mar 21, 2024 · 1 comment
Closed

Enable gzip compression on file writing #129

theferrit32 opened this issue Mar 21, 2024 · 1 comment
Assignees
@theferrit32

Comments

@theferrit32
Copy link
Contributor

theferrit32 commented Mar 21, 2024 •
edited

Might want to add an optional flag to enable gzip, and write plaintext ndjson files otherwise (as we do now)

get_open_file_for_writing actually already supports this if you override the suffix argument with .ndjson.gz rather than the default .ndjson. We just need to have parse_and_write_files accept a gzip boolean flag from the main parse function, or just hardcode it to use that suffix.
@theferrit32
Copy link
Contributor Author

Closed by #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theferrit32 theferrit32

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theferrit32