New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Zonal Diffusion #179
base: main
Are you sure you want to change the base?
Adds Zonal Diffusion #179
Conversation
Hi @HenryDane, this looks awesome! Thanks for the contribution, and especially for including tests with your PR! It may take me a bit of time to digest everything you've done here. |
Fixes missing import for `climlab.const` as per Brian Rose's recommendation. Co-authored-by: Brian Rose <brose@albany.edu>
I committed the change you suggested -- thanks very much for pointing that out to me. It looks like all the tests are passing now. |
Great! I'll take a closer look at the code when I get a chance. |
I've been adding commits here (f256da through 4a6ba5b) to fix an issue I noticed with this new version where if a model had both zonal and meridional adv-diff processes, the fluxes ( These new commits fix this problem by adding an optional With these changes, I believe that zonal advection-diffusion, zonal heat diffusion, and zonal moist diffusion should now work correctly both on their own and in the presence of other adv-diff processes. |
@HenryDane can you merge in the latest changes from main branch into this PR? That will clear up the unrelated test failures. |
Merge climlab/main into diff_lon
Yes, of course. I just applied the merge and all the tests seem to be passing now. |
This pull request adds zonal advection-diffusion, zonal heat diffusion, and zonal moist diffusion. Additionally, this makes the adv-diff solver support periodic boundary conditions.
I've also added some unit tests to verify that the changes work.
Please let me know if you have any comments or feedback or questions.