Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add padding below "Next button" #78

Merged
merged 2 commits into from May 23, 2024

Conversation

sfishel18
Copy link
Contributor

#76

@sfishel18
Copy link
Contributor Author

before:

Screen Shot 2024-05-10 at 7 32 53 PM

after:

Screen Shot 2024-05-10 at 7 29 45 PM

@sfishel18
Copy link
Contributor Author

@rgraue i got an email from github with a comment from you on this PR pointing out that it would be better not to use a static pixel value for this padding. for some reason i don't see that comment on the PR itself though.

but anyway, that's a good call, and i was going to follow up and ask if you prefer % vs rem vs vh for the dynamic version of the padding

@rgraue
Copy link
Collaborator

rgraue commented May 19, 2024

@rgraue i got an email from github with a comment from you on this PR pointing out that it would be better not to use a static pixel value for this padding. for some reason i don't see that comment on the PR itself though.

but anyway, that's a good call, and i was going to follow up and ask if you prefer % vs rem vs vh for the dynamic version of the padding

Weird... might be a setting for pr comments. I'll look around those and see
I think % might be the best for what were looking for here... although im no style wizard, so maybe em might be good too, if we want it to inherit from whatever class its nested in

@sfishel18
Copy link
Contributor Author

@rgraue i got an email from github with a comment from you on this PR pointing out that it would be better not to use a static pixel value for this padding. for some reason i don't see that comment on the PR itself though.
but anyway, that's a good call, and i was going to follow up and ask if you prefer % vs rem vs vh for the dynamic version of the padding

Weird... might be a setting for pr comments. I'll look around those and see I think % might be the best for what were looking for here... although im no style wizard, so maybe em might be good too, if we want it to inherit from whatever class its nested in

updated the PR to use %, seems to be working well to my eye

src/styles/page.css Outdated Show resolved Hide resolved
@rgraue rgraue merged commit 2a7cfc3 into climate-cooperative:main May 23, 2024
@sfishel18 sfishel18 deleted the next-button-spacing branch May 25, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants