Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr/ios sdk docs #926

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Pr/ios sdk docs #926

wants to merge 14 commits into from

Conversation

mikepitre
Copy link

This PR adds the following:

  1. Quick Start Guide for iOS
  2. iOS SDK Reference section containing:
    • Overview
    • Installation Guide
    • Custom Flows

I am initially marking this PR as a draft, as there are a few todos remaining:

  1. Need to add an Apple icon for the SDK reference sidebar.
  2. Some of the links in the new custom flows section still link back to the original custom flows section.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited by bradlc

Hey, here’s your docs preview: https://clerk.com/docs/pr/926

@S3Prototype S3Prototype self-requested a review April 22, 2024 14:38
@mikepitre mikepitre marked this pull request as ready for review April 22, 2024 15:44
@mikepitre mikepitre requested a review from a team as a code owner April 22, 2024 15:44
S3Prototype
S3Prototype reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@S3Prototype S3Prototype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the rest of this is largely duplicated, I only have edits for the quickstart 👍

@mikepitre mikepitre marked this pull request as draft April 23, 2024 18:14
@bradlc
Copy link
Member

bradlc commented May 9, 2024

Hey! It looks like your PR makes changes to the docs/manifest.json file. The manifest schema was recently updated so you will need to update your PR to account for this. You can see the updated documentation for the manifest here: https://github.com/clerk/clerk-docs/blob/main/CONTRIBUTING.md#navigation-manifest

If you need help with this, or would like me to make the necessary changes on your behalf please tag me in this PR or DM me on Slack 🤙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S3Prototype S3Prototype S3Prototype left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Blocked deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikepitre @bradlc @S3Prototype @kylemac