Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Clerk Koa SDK (community) #809

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dimkl
Copy link
Member

@dimkl dimkl commented Mar 14, 2024

Related PR for adding the icon: https://github.com/clerk/clerk-marketing/pull/920

@dimkl dimkl self-assigned this Mar 14, 2024
@dimkl dimkl requested a review from a team as a code owner March 14, 2024 02:49
@alexisintech
Copy link
Member

hey friend! you can upload the koa icon like how I did in this PR for the clerk icon:
https://github.com/clerk/clerk-marketing/pull/908

16x16 svg

Copy link

github-actions bot commented Apr 3, 2024

Hey @S3Prototype, your docs preview is available.

Status Preview Updated (UTC)
🍪 Updated Visit preview Apr 22, 2024 02:25 PM

@dimkl dimkl requested a review from alexisintech April 3, 2024 23:07
@alexisintech
Copy link
Member

hmm.. I pulled both branches and am trying to check locally, but it doesn't seem to be appearing. I don't see anything wrong with the code, so I think it's the SVG.

Screen.Recording.2024-04-04.at.11.15.52.mov

So then I test the SVG, and yes, it comes up as nothing?

Screenshot 2024-04-04 at 11 17 14

@S3Prototype
Copy link
Contributor

@dimkl Soft reminder about this PR

@bradlc
Copy link
Member

bradlc commented May 9, 2024

Hey! It looks like your PR makes changes to the docs/manifest.json file. The manifest schema was recently updated so you will need to update your PR to account for this. You can see the updated documentation for the manifest here: https://github.com/clerk/clerk-docs/blob/main/CONTRIBUTING.md#navigation-manifest

If you need help with this, or would like me to make the necessary changes on your behalf please tag me in this PR or DM me on Slack 🤙

@dimkl
Copy link
Member Author

dimkl commented May 24, 2024

Both PRs rebased and updated!
@alexisintech , @S3Prototype , @bradlc PTAL

Copy link
Contributor

@S3Prototype S3Prototype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I approved the other PR as well that adds the icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants