Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes, Page Aliases, Redaction, Local Media, Layout Customization, Asset Imports & Case (De)Sensitivity #247

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

rj919
Copy link

@rj919 rj919 commented Aug 27, 2018

I've consolidated the features from prior pull requests with another fix to a bug in jingo's core code I uncovered as well as an additional option in configs to turn off case sensitivity to page linking. An explanation of all the features added along with the documentation for each feature can be found here:

https://github.com/rj919/jingo/blob/master/README_FORK.md

Look forward to seeing jingo v2...

As far as additional features which I have thought about but haven't been able to get to yet, here are some ideas:

  • A template/blueprint/widget system which allows redactable (and/or auto-generated) data to be mapped onto a page and rendered in the appropriate markdown/html format. In this way, data in formats like yaml, json or csv could be rendered as tables, diagrams, graphs and other html stylized elements.
  • A way to load files into the media sub-directory directly from the wiki. Currently, my code only supports files which are already on the server.
  • Similarly, a way to create alias for pages directly in the wiki interface. Once again, my code only supports aliases which have been added to the config.yaml file, which requires a reboot of jingo to update and would be difficult to maintain if jingo was being edited live by many online users.
  • A way to lift block html elements outside of paragraphs as markdown is being rendered
  • A way to add markdown flavors/options to page rendering which support expanded syntax such as the ones used by github or mediawiki

rj919 added 30 commits July 26, 2018 22:03
…guration fields to config.js; added validation of new configuration fields;
…ion of sidebar, footer and main columns to layout.pug;
…n; fixed bug in gitmech.gitExec when handling absolute paths with blank spaces;
…edirection functionality to wiki page and link interpolation; updated default redaction expressions in config; TODO: add validation of redaction expressions and validate date fields exist in earliestDate;
…ummaries as option in config; TODO: add redactContent and pageSummaries to pug templates; add validation of redaction expressions and validate date fields exist in earliestDate; integrate redaction RegExp tests to redactor.redact;
…h search result fetching; TODO: add validation of redaction expressions and validate date fields exist in earliestDate; integrate redaction RegExp tests to redactor.redact;
… hidden, private and date based redaction; TODO: finish rollout sections RegExp tests to redactor.redact; TODO: add media to routes served
…ch.js; added override of standard favicon with favicon in media folder;
…untu; added option to serve files from local copies rather than CDNs to config; removed case sensitive toggle from search results - now case sensitivity applies only to redirect names;
…ction matches; added a privateComments redaction option to allow for inline (non-sandwich) redaction; added README_FORK documentation for changes; TODO: finish documentation of redaction options;
…; TODO: finish documentation of redaction options;
…; added unittests for additional fields added to config; added documentation to README_FORK.md;
… aliases into page editing so alias can be added by live users; TODO: lift html elements outside of paragraphs during markdown rendering; TODO: add route to retrieve data files which can be redacted; TODO: add option to auto-generate tables and other data objects into page; TODO: add plugin option for a different flavor of markdown;
…nto page editing so alias can be added by live users; TODO: lift html elements outside of paragraphs during markdown rendering; TODO: add route to retrieve data files which can be redacted; TODO: add option to auto-generate tables and other data objects into page; TODO: add plugin option for a different flavor of markdown;
…e editing so alias can be added by live users; TODO: lift html elements outside of paragraphs during markdown rendering; TODO: add route to retrieve data files which can be redacted; TODO: add option to auto-generate tables and other data objects into page; TODO: add plugin option for a different flavor of markdown;
… markdown rendering; TODO: integrate aliases into page editing so alias can be added by live users; TODO: add option to auto-generate tables and other data objects into page; TODO: add plugin option for a different flavor of markdown;
@claudioc
Copy link
Owner

claudioc commented Oct 3, 2018

@rj919 if want to take a look at Jingo 2, just give me an email address and I will share it with you (it's still in a private bitbucket repo at the moment)

@rj919
Copy link
Author

rj919 commented Oct 5, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants