Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support login through Mastodon API. #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support login through Mastodon API. #239

wants to merge 1 commit into from

Conversation

Feufochmar
Copy link

This commit add Mastdon as an option for login by using mastodon-passport.

Mastodon being a federated social network, there are several instances of the service, so you need to know against which server you do the authentication. In this commit, a domain parameter in the configuration file indicate this.
If users from different instances should be able to log in, this commit must be improved to ask the domain on the login page.

This commit also reorganises a bit the auth.js file by regrouping the code related to a login method inside the same if block. This has the effect of not exposing unneeded API endpoints is those are disabled in the configuration.

This pull request is mainly for reference, as I've seen that you haven't merged similar pull requests.

@claudioc
Copy link
Owner

claudioc commented Aug 4, 2018

@Feufochmar first of all, thank you for understanding my position on this topic; I rather not merge all the requests for new auth method, simply because with current Jingo's architecture (not "pluggable") it'd be a complete nightmare to test all the integration whenever a new change is made :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants