Support authentication through Github Enterprise #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config.yml is consulted for various Github URLs so that Jingo can connect to Github instances hosted at arbitrary locations. E.g. to login using https://mygithub.com one can add the following configuration (tested with Github Enterprise 2.6): github: enabled: true redirectURL: '' clientId: <clientid> clientSecret: <clientsecret> authorizationURL: https://mygithub.com/login/oauth/authorize tokenURL: https://mygithub.com/login/oauth/access_token userProfileURL: https://mygithub.com/api/v3/user
claudioc
requested changes
Jan 8, 2017
| callbackURL: redirectURL, | ||
| authorizationURL: auth.github.authorizationURL, | ||
| tokenURL: auth.github.tokenURL, | ||
| userProfileURL: auth.github.userProfileURL |
There was a problem hiding this comment.
What if those values are not provided in the config.yaml (they'll be set as undefined and this would probably cause issues)?
The config.js needs also to be updated to provide default values (empty strings?) for those.
Also, we could test for these values to be present before using them.
And finally, any configuration option needs also to be referenced in the README file.
Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.yml is consulted for various Github URLs so that
Jingo can connect to Github instances hosted at arbitrary locations.
E.g. to login using https://mygithub.com one can add the following
configuration (tested with Github Enterprise 2.6):
github:
enabled: true
redirectURL: ''
clientId:
clientSecret:
authorizationURL: https://mygithub.com/login/oauth/authorize
tokenURL: https://mygithub.com/login/oauth/access_token
userProfileURL: https://mygithub.com/api/v3/user