Vm values #1502
Draft
Vm values #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since compile_fdesignator skips compile_form, the code walker wouldn't see e.g. the c-n-m in (funcall #'call-next-method ...).
From a few microbenchmarks this appears to improve some performance marginally; but I'd like to include it for other reasons: 1) This way (apply #'foo ...) shows up as a call to FOO in xref, and not as a call to APPLY. 2) The bytecode is a little nicer for BTB purposes since this matches how we treat APPLY in clasp-cleavir. It matches the philosophy of having M-V-C as _the_ variadic call mechanism.
This lets us move the APPLY compiler macro out of cclasp-specific-land.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor performance improvements to how the VM handles multiple values. Mostly it lets the compiler macro expanding
applyintomultiple-value-callbe shared between bytecode and cclasp, which I think is nice.This is hardly a high priority and it changes the VM definition, so this'll be a draft for a while