Skip to content

Commit

Permalink
notes
Browse files Browse the repository at this point in the history
  • Loading branch information
clarisma committed Mar 24, 2023
1 parent 33f10ce commit 6922b6f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions src/main/java/com/geodesk/feature/store/FeatureStore.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ public class FeatureStore extends BlobStore
* TODO: Currently, empty string is *not* in this map (since 0 means
* "this key is not a global string"); should we revise this definition?
*
* TODO: No need to index more than 8K strings; we only look up keys,
* and key-codes cannot be > 8 K
* No! Query Compiler needs to look up values as well
*/
private ObjectIntMap<String> stringsToCodes;
/**
Expand Down Expand Up @@ -128,6 +131,9 @@ private void readStringTable()
// 1/11/23: Changed to include "" as entry 0
// (to determine if a key is not in the table, must supply -1 as default)

// TODO: only index first 8K strings
// No! Query Compiler needs to look up values as well

for (int i = 1; i <= count; i++)
{
String s = reader.readString();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public TileIndexWalker(ByteBuffer buf, int pTileIndex, int zoomLevels)
// initialize the root

level = root;
level.extent >>>= 1; // fix the root extent
level.extent >>>= 1; // fix the root extent // TODO: check, needed?
level.childTileMask = ~0; // root tile raster is always dense
level.pChildEntries = pTileIndex + 4; // skip purgatory tile
}
Expand Down

0 comments on commit 6922b6f

Please sign in to comment.