Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border to menu bar. #16320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mremiszewski
Copy link
Contributor

Suggested merge commit message (convention)

Other (editor-classic): Add a separator between the menu bar and the toolbar.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@mremiszewski mremiszewski requested a review from scofalik May 7, 2024 14:38
Copy link
Contributor

coderabbitai bot commented May 7, 2024

Walkthrough

The update primarily focuses on enhancing the visual aesthetics of the CKEditor's classic theme by modifying the border properties of the .ck-menu-bar class. This adjustment aims to improve the overall look of the menu bar, ensuring a more appealing and user-friendly interface.

Changes

File Path Change Summary
.../ckeditor5-theme-lark/.../classiceditor.css Updated border properties of .ck-menu-bar to enhance appearance.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 04a8c63 and 0e5ae85.
Files selected for processing (1)
  • packages/ckeditor5-theme-lark/theme/ckeditor5-editor-classic/classiceditor.css (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/ckeditor5-theme-lark/theme/ckeditor5-editor-classic/classiceditor.css

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@scofalik
Copy link
Contributor

scofalik commented May 7, 2024

We should also try to make the separators look better.

Right now it is like this:

Separators + border makes it crowdy, it looks like a grid.

Proposal:

Separators are a bit smaller, there is a bit more breathing room.

I added height equal to --ck-icon-size and removed align-self:

@oleq -- WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants