[IME+Android] The MutationObserver should not break text nodes.
#16300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges, not as a normal flow in IME. Composed text on Android should be inserted to the model only after it is available in the DOM (so on beforeinput is too early). So no mutations other by those made by IME.
…er avoiding programmatic DOM changes while composing.
…osition mutations on composition end.
… of mutations vs composition elements.
…the model to avoid reverting DOM changes and the re-applying them.
| * by default in all editor instances (attached by {@link module:engine/view/view~View}). | ||
| * | ||
| * @eventName module:engine/view/document~Document#mutations | ||
| * @param data Event data containing detailed information about the event. |
There was a problem hiding this comment.
data is not available below.
Comment on lines
+296
to
+306
| export type MutationsEventData = { | ||
| mutations: Array<MutationData>; | ||
| }; | ||
|
|
||
| /** | ||
| * A single entry in {@link ~MutationsEventData} mutations array. | ||
| */ | ||
| export type MutationData = { | ||
| type: ChangeType; | ||
| node: ViewNode; | ||
| }; |
There was a problem hiding this comment.
Missing field description.
| // @if CK_DEBUG_TYPING // console.info( '%c[Renderer]%c Rendering aborted while isComposing', | ||
| // @if CK_DEBUG_TYPING // 'color: green;font-weight: bold', '' | ||
| // @if CK_DEBUG_TYPING // console.info( '%c[Renderer]%c Rendering aborted while isComposing.', | ||
| // @if CK_DEBUG_TYPING // 'color: green;font-weight: bold', 'font-style: italic' |
There was a problem hiding this comment.
Suggested change
| // @if CK_DEBUG_TYPING // 'color: green;font-weight: bold', 'font-style: italic' | |
| // @if CK_DEBUG_TYPING // 'color: green; font-weight: bold', 'font-style: italic' |
And below.
Comment on lines
+237
to
+238
| // At this point we have "dirty DOM" (changed) and de-synched view (which has not been changed). | ||
| // In order to "reset DOM" we render the view again. |
There was a problem hiding this comment.
Maybe this can be adjusted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (engine, typing): Typing on Android should avoid modifying DOM while composing. Closes #13994. Closes #14707. Closes #13850.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.